gh-127174: add some advice for asyncio.get_event_loop replacements#127640
Merged
kumaraditya303 merged 9 commits intopython:mainfrom Dec 18, 2024
Merged
gh-127174: add some advice for asyncio.get_event_loop replacements#127640kumaraditya303 merged 9 commits intopython:mainfrom
kumaraditya303 merged 9 commits intopython:mainfrom
Conversation
Co-authored-by: Kumar Aditya <kumaraditya@python.org>
Member
StanFromIreland
left a comment
StanFromIreland
left a comment
There was a problem hiding this comment.
I think a few small changes would be good.
graingert
commented
Dec 6, 2024
graingert
commented
Dec 6, 2024
graingert
commented
Dec 6, 2024
picnixz
reviewed
Dec 7, 2024
Member
picnixz
left a comment
picnixz
left a comment
There was a problem hiding this comment.
Your before/after should be capitalized as they introduce a new paragraph. To reduce the length of the text, how about putting ... on the same line as def?
srinivasreddy
pushed a commit
to srinivasreddy/cpython
that referenced
this pull request
Jan 8, 2025
…thon#127640) Co-authored-by: Kumar Aditya <kumaraditya@python.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📚 Documentation preview 📚: https://cpython-previews--127640.org.readthedocs.build/