-
-
Notifications
You must be signed in to change notification settings - Fork 33.9k
[3.13] Fix grammar typo in Doc/c-api/arg.rst (GH-130741)
#130759
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
(cherry picked from commit 37145cb) Co-authored-by: Arijit Kumar Das <arijitkrdas2004@outlook.com>
|
@hugovk That's weird, the CLA was signed on the original PR. What happened here? |
|
I think it's because the user probably has a gmail.com email in their GitHub account (used for #130741) and signed the CLA with that, but has a different outlook.com email in the commit used here: https://github.com/python/cpython/pull/130759.patch |
|
So, IIUC, we have a commit whose CLA that is signed with a different email than the commit's email. Since we already merged that commit in main, can we assume that the CLA was properly signed? (can you unsign the CLA?) |
|
Probably, but the CLA bot is a required status check. The easiest thing is for the contributor to also sign the CLA with the other email. (Another option is to amend the commit in the backport and force push.) @ArijitKD Please could you also sign the CLA with your outlook.com email address? See #130759 (comment). |
|
@hugovk CLA signed. That outlook.com is actually not the email I use for github commits. Probably got swapped somehow. Anyways, this is ready to be merged now! |
|
Thank you! |
(cherry picked from commit 37145cb)
Co-authored-by: Arijit Kumar Das arijitkrdas2004@outlook.com
📚 Documentation preview 📚: https://cpython-previews--130759.org.readthedocs.build/