[3.7] bpo-27639: Correct return type for UserList slicing operation #13203
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added logic to __getitem__ magic method for UserList to ensure that the return type matches that of self.
mblahay
changed the title
mblahay
changed the title
Contributor
Author
|
This needs to be merged. |
Member
|
@markshannon because you merged the #13169 maybe you could merge this one. |
Contributor
Author
|
@markshannon it has been another week. This is the same change as was made in 3.8. Please provide any feedback that you believe is necessary. I would like it if this didn't hang out there too much longer. |
Member
|
Sorry about the delay. LGTM. |
|
@markshannon: Please replace |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added logic to getitem magic method for UserList to ensure that the return
type matches that of self.
https://bugs.python.org/issue27639