gh-136447: Use self.loop instead of global loop variable in asyncio REPL
#136448
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
injust
requested review from
1st1,
asvetlov,
kumaraditya303 and
willingc
as code owners
|
All commit authors signed the Contributor License Agreement. |
|
Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool. If this change has little impact on Python users, wait for a maintainer to apply the |
kumaraditya303
approved these changes
Jul 9, 2025
kumaraditya303
added
needs backport to 3.13
|
Thanks @injust for the PR, and @kumaraditya303 for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13. |
|
Thanks @injust for the PR, and @kumaraditya303 for merging it 🌮🎉.. I'm working now to backport this PR to: 3.14. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jul 9, 2025
… asyncio REPL (pythonGH-136448) (cherry picked from commit 77fa7a4) Co-authored-by: Justin Su <injustsu@gmail.com>
|
GH-136457 is a backport of this pull request to the 3.13 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jul 9, 2025
… asyncio REPL (pythonGH-136448) (cherry picked from commit 77fa7a4) Co-authored-by: Justin Su <injustsu@gmail.com>
|
GH-136458 is a backport of this pull request to the 3.14 branch. |
kumaraditya303
pushed a commit
that referenced
this pull request
Jul 9, 2025
kumaraditya303
pushed a commit
that referenced
this pull request
Jul 9, 2025
AndPuQing
pushed a commit
to AndPuQing/cpython
that referenced
this pull request
Jul 11, 2025
… asyncio REPL (python#136448)
Pranjal095
pushed a commit
to Pranjal095/cpython
that referenced
this pull request
Jul 12, 2025
… asyncio REPL (python#136448)
picnixz
pushed a commit
to picnixz/cpython
that referenced
this pull request
Jul 13, 2025
… asyncio REPL (python#136448)
taegyunkim
pushed a commit
to taegyunkim/cpython
that referenced
this pull request
Aug 4, 2025
… asyncio REPL (python#136448)
Agent-Hellboy
pushed a commit
to Agent-Hellboy/cpython
that referenced
this pull request
Aug 19, 2025
… asyncio REPL (python#136448)
kumaraditya303
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Sep 9, 2025
…able in asyncio REPL (pythonGH-136448) (python#136458) pythongh-136447: Use `self.loop` instead of global `loop` variable in asyncio REPL (pythonGH-136448) (cherry picked from commit 77fa7a4) Co-authored-by: Justin Su <injustsu@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
loopis passed toAsyncIOInteractiveConsoleand assigned to the instance attributeself.loop.This PR fixes the one place where
AsyncIOInteractiveConsoleuses the globalloopvariable instead ofself.loop.self.loopinstead of globalloopvariable inAsyncIOInteractiveConsole#136447