Skip to content

improve isolation of test_pending_call_creates_thread_subinterpreter #139473

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
kumaraditya303 wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

improve isolation of test_pending_call_creates_thread_subinterpreter #139473

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0cb09f9
improve isolation of test_pending_call_creates_thread_subinterpreter
kumaraditya303 Oct 1, 2025
81f305f
improve isolation of test_pending_call_creates_thread_subinterpreter
kumaraditya303 Oct 1, 2025
792c27f
remove marker
kumaraditya303 Oct 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 13 additions & 12 deletions Lib/test/test_capi/test_misc.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1981,12 +1981,11 @@ def test_module_state_shared_in_global(self):
self.assertEqual(main_attr_id, subinterp_attr_id)

@threading_helper.requires_working_threading()
@unittest.skipUnless(hasattr(os, "pipe"), "requires os.pipe()")
@requires_subinterpreters
def test_pending_call_creates_thread_subinterpreter(self):
interpreters = import_helper.import_module("concurrent.interpreters")
r, w = os.pipe()
# For better isolation, run the entire test in a different subprocess.
source = f"""if True:
code = '''if True:
import _testinternalcapi
import threading
import time
Expand All @@ -1995,9 +1994,7 @@ def test_pending_call_creates_thread_subinterpreter(self):

def output():
time.sleep(1)
os.write({w}, b"x")
os.close({w})

print("x", end="")

def callback():
threading.Thread(target=output).start()
Expand All @@ -2007,15 +2004,19 @@ def create_pending_call():
time.sleep(1)
_testinternalcapi.simple_pending_call(callback)


threading.Thread(target=create_pending_call).start()
"""
'''

import concurrent.interpreters as interpreters

interp = interpreters.create()
interp.exec(source)
interp.exec(code)
interp.close()
data = os.read(r, 1)
self.assertEqual(data, b"x")
os.close(r)
"""
rc, out, err = assert_python_ok('-c', source)
self.assertEqual(rc, 0)
self.assertEqual(out, b"x")
self.assertEqual(err, b"")


@requires_subinterpreters
Expand Down
Loading