gh-62480: De-personalize "Partial mocking" section in unittest.mock examples
#141321
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some of the descriptions were addressed in first person, but have now been changed to address the user reading the documentation instead.
|
All commit authors signed the Contributor License Agreement. |
bedevere-app
bot
added
awaiting review
docs
CAM-Gerlach
changed the title
CAM-Gerlach
changed the title
CAM-Gerlach
requested changes
Nov 9, 2025
Member
CAM-Gerlach
left a comment
CAM-Gerlach
left a comment
There was a problem hiding this comment.
Thanks! Some further textual refinements, otherwise LGTM
|
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated. Once you have made the requested changes, please leave a comment on this pull request containing the phrase |
CAM-Gerlach
added
needs backport to 3.13
Co-authored-by: C.A.M. Gerlach <CAM.Gerlach@Gerlach.CAM>
Co-authored-by: C.A.M. Gerlach <CAM.Gerlach@Gerlach.CAM>
Co-authored-by: C.A.M. Gerlach <CAM.Gerlach@Gerlach.CAM>
Co-authored-by: C.A.M. Gerlach <CAM.Gerlach@Gerlach.CAM>
Co-authored-by: C.A.M. Gerlach <CAM.Gerlach@Gerlach.CAM>
KarnbirKhera
commented
Nov 9, 2025
Contributor
Author
KarnbirKhera
left a comment
KarnbirKhera
left a comment
There was a problem hiding this comment.
Changes make the document more accurate. Added to original request.
picnixz
changed the title
unittest.mock examples
CAM-Gerlach
approved these changes
Nov 9, 2025
Member
CAM-Gerlach
left a comment
CAM-Gerlach
left a comment
There was a problem hiding this comment.
LGTM now, thanks @KarnbirKhera !
|
Thanks @KarnbirKhera for the PR, and @CAM-Gerlach for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Nov 9, 2025
….mock` examples (pythonGH-141321) * Refine some wording in unittest partial mock doc Some of the descriptions were addressed in first person, but have now been changed to address the user reading the documentation instead. (cherry picked from commit b618731) Co-authored-by: KarnbirKhera <166065758+KarnbirKhera@users.noreply.github.com> Co-authored-by: C.A.M. Gerlach <CAM.Gerlach@Gerlach.CAM>
|
GH-141326 is a backport of this pull request to the 3.14 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Nov 9, 2025
….mock` examples (pythonGH-141321) * Refine some wording in unittest partial mock doc Some of the descriptions were addressed in first person, but have now been changed to address the user reading the documentation instead. (cherry picked from commit b618731) Co-authored-by: KarnbirKhera <166065758+KarnbirKhera@users.noreply.github.com> Co-authored-by: C.A.M. Gerlach <CAM.Gerlach@Gerlach.CAM>
|
GH-141327 is a backport of this pull request to the 3.13 branch. |
CAM-Gerlach
added a commit
that referenced
this pull request
Nov 10, 2025
…t.mock` examples (GH-141321) (#141327) gh-62480: De-personalize "Partial mocking" section in `unittest.mock` examples (GH-141321) * Refine some wording in unittest partial mock doc Some of the descriptions were addressed in first person, but have now been changed to address the user reading the documentation instead. (cherry picked from commit b618731) Co-authored-by: KarnbirKhera <166065758+KarnbirKhera@users.noreply.github.com> Co-authored-by: C.A.M. Gerlach <CAM.Gerlach@Gerlach.CAM>
CAM-Gerlach
added a commit
that referenced
this pull request
Nov 10, 2025
…t.mock` examples (GH-141321) (#141326) gh-62480: De-personalize "Partial mocking" section in `unittest.mock` examples (GH-141321) * Refine some wording in unittest partial mock doc Some of the descriptions were addressed in first person, but have now been changed to address the user reading the documentation instead. (cherry picked from commit b618731) Co-authored-by: KarnbirKhera <166065758+KarnbirKhera@users.noreply.github.com> Co-authored-by: C.A.M. Gerlach <CAM.Gerlach@Gerlach.CAM>
StanFromIreland
pushed a commit
to StanFromIreland/cpython
that referenced
this pull request
Dec 6, 2025
….mock` examples (python#141321) * Refine some wording in unittest partial mock doc Some of the descriptions were addressed in first person, but have now been changed to address the user reading the documentation instead. Co-authored-by: C.A.M. Gerlach <CAM.Gerlach@Gerlach.CAM>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some of the descriptions were addressed in first person, but have now been changed to address the user reading the documentation instead.
📚 Documentation preview 📚: https://cpython-previews--141321.org.readthedocs.build/