Skip to content

bpo-35031, test_asycio: disable TLS 1.3 in test_start_tls_server_1() #14148

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
vstinner merged 1 commit into from
Jun 17, 2019
Merged

bpo-35031, test_asycio: disable TLS 1.3 in test_start_tls_server_1() #14148

vstinner merged 1 commit into from
Jun 17, 2019

Conversation

@vstinner
Copy link
Member

@vstinner vstinner commented Jun 17, 2019 •
edited by bedevere-bot
Loading

Reintroduce workaround on Windows and FreeBSD in
test_start_tls_server_1() of test_asyncio: disable TLS v1.3 on the
client context.

https://bugs.python.org/issue35031

@vstinner vstinner requested a review from tiran as a code owner June 17, 2019 09:06
@bedevere-bot bedevere-bot added tests Tests in the Lib/test dir awaiting core review labels Jun 17, 2019
@vstinner
bpo-35031, test_asycio: disable TLS 1.3 in test_start_tls_server_1()
d9ef52d 
bpo-35031, bpo-35998: Reintroduce workaround on Windows and FreeBSD
in test_start_tls_server_1() of test_asyncio: disable TLS v1.3 on the
client context.
@vstinner
Copy link
Member Author

vstinner commented Jun 17, 2019

test_asyncio restarted to fail on Windows buildbots after the commit f0749da backported to 3.7 and 3.8 branches:
https://bugs.python.org/issue35998#msg345644

This PR doesn't really make the situation way worse: we use this workaround since October 2018.
https://bugs.python.org/issue35031#msg328871

If someone can have a look at the root issue, it would be great, but in the meanwhile, we need the CI to be green again (and reliable).

cc @tiran @asvetlov @1st1 @pablogsal

asvetlov
asvetlov approved these changes Jun 17, 2019
View reviewed changes
Copy link
Contributor

@asvetlov asvetlov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If it can fix buildbots -- I'm ok with suppressing the test

@vstinner
Copy link
Member Author

vstinner commented Jun 17, 2019

If it can fix buildbots -- I'm ok with suppressing the test

Well, this PR doesn't remove the test, it only works around a failure on 2 platforms: only test TLS 1.2 on Windows and FreeBSD.

I heard that asyncio and ssl have issues on TLS 1.3 which handles TLS shutdown differently, but it seems like nobody has time to work on this issue.

@vstinner vstinner merged commit c034b78 into python:master Jun 17, 2019
@miss-islington
Copy link
Contributor

miss-islington commented Jun 17, 2019

Thanks @vstinner for the PR 🌮🎉.. I'm working now to backport this PR to: 3.7, 3.8.
🐍🍒⛏🤖

@vstinner vstinner deleted the start_tls_server_1_tls13 branch June 17, 2019 09:47
@bedevere-bot
Copy link

bedevere-bot commented Jun 17, 2019

GH-14150 is a backport of this pull request to the 3.8 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jun 17, 2019
@vstinner @miss-islington
bpo-35031, test_asycio: disable TLS 1.3 in test_start_tls_server_1() (p…
d72d96b 
…ythonGH-14148)

bpo-35031, bpo-35998: Reintroduce workaround on Windows and FreeBSD
in test_start_tls_server_1() of test_asyncio: disable TLS v1.3 on the
client context.
(cherry picked from commit c034b78)

Co-authored-by: Victor Stinner <vstinner@redhat.com>
@bedevere-bot
Copy link

bedevere-bot commented Jun 17, 2019

GH-14151 is a backport of this pull request to the 3.7 branch.

miss-islington added a commit that referenced this pull request Jun 17, 2019
@miss-islington @vstinner
bpo-35031, test_asycio: disable TLS 1.3 in test_start_tls_server_1() (G…
a5ddbfb 
…H-14148)

bpo-35031, bpo-35998: Reintroduce workaround on Windows and FreeBSD
in test_start_tls_server_1() of test_asyncio: disable TLS v1.3 on the
client context.
(cherry picked from commit c034b78)

Co-authored-by: Victor Stinner <vstinner@redhat.com>
miss-islington added a commit that referenced this pull request Jun 17, 2019
@miss-islington @vstinner
bpo-35031, test_asycio: disable TLS 1.3 in test_start_tls_server_1() (G…
0040903 
…H-14148)

bpo-35031, bpo-35998: Reintroduce workaround on Windows and FreeBSD
in test_start_tls_server_1() of test_asyncio: disable TLS v1.3 on the
client context.
(cherry picked from commit c034b78)

Co-authored-by: Victor Stinner <vstinner@redhat.com>
lisroach pushed a commit to lisroach/cpython that referenced this pull request Sep 10, 2019
@vstinner @lisroach
bpo-35031, test_asycio: disable TLS 1.3 in test_start_tls_server_1() (p…
f9dc8e8 
…ythonGH-14148)

bpo-35031, bpo-35998: Reintroduce workaround on Windows and FreeBSD
in test_start_tls_server_1() of test_asyncio: disable TLS v1.3 on the
client context.
DinoV pushed a commit to DinoV/cpython that referenced this pull request Jan 14, 2020
@vstinner @DinoV
bpo-35031, test_asycio: disable TLS 1.3 in test_start_tls_server_1() (p…
c534719 
…ythonGH-14148)

bpo-35031, bpo-35998: Reintroduce workaround on Windows and FreeBSD
in test_start_tls_server_1() of test_asyncio: disable TLS v1.3 on the
client context.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@asvetlov asvetlov asvetlov approved these changes

@tiran tiran Awaiting requested review from tiran

Assignees

No one assigned

Labels

skip news tests Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@vstinner @miss-islington @bedevere-bot @asvetlov @the-knights-who-say-ni