Skip to content

gh-142543: Mark tracer functions as Py_NO_INLINE #142846

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Fidget-Spinner merged 5 commits into from
Dec 17, 2025
+6 −3
Merged

gh-142543: Mark tracer functions as Py_NO_INLINE #142846

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
7fced44
Mark tracer function as Py_NO_INLINE
Fidget-Spinner Dec 16, 2025
8f854b8
mark more things as noinline
Fidget-Spinner Dec 16, 2025
87ceff2
📜🤖 Added by blurb_it.
blurb-it[bot] Dec 16, 2025
8ff4a63
add comments
Fidget-Spinner Dec 16, 2025
04cf03a
Merge branch 'no_inilne_tracer' of github.com:Fidget-Spinner/cpython …
Fidget-Spinner Dec 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions Misc/NEWS.d/next/Core_and_Builtins/2025-12-16-23-26-41.gh-issue-142543.wJKjBs.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Fix a stack overflow on Clang JIT build configurations with full LTO.
8 changes: 5 additions & 3 deletions Python/optimizer.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -582,7 +582,8 @@ is_terminator(const _PyUOpInstruction *uop)

/* Returns 1 on success (added to trace), 0 on trace end.
*/
int
// gh-142543: inlining this function causes stack overflows
Py_NO_INLINE int
_PyJit_translate_single_bytecode_to_trace(
PyThreadState *tstate,
_PyInterpreterFrame *frame,
Expand Down Expand Up @@ -994,7 +995,8 @@ _PyJit_translate_single_bytecode_to_trace(
}

// Returns 0 for do not enter tracing, 1 on enter tracing.
int
// gh-142543: inlining this function causes stack overflows
Py_NO_INLINE int
_PyJit_TryInitializeTracing(
PyThreadState *tstate, _PyInterpreterFrame *frame, _Py_CODEUNIT *curr_instr,
_Py_CODEUNIT *start_instr, _Py_CODEUNIT *close_loop_instr, int curr_stackdepth, int chain_depth,
Expand Down Expand Up @@ -1066,7 +1068,7 @@ _PyJit_TryInitializeTracing(
return 1;
}

void
Py_NO_INLINE void
_PyJit_FinalizeTracing(PyThreadState *tstate)
{
_PyThreadStateImpl *_tstate = (_PyThreadStateImpl *)tstate;
Expand Down
Loading