Skip to content

Conversation

@hugovk
Copy link
Member

@hugovk hugovk commented Dec 18, 2025

Before

In dark mode, the samples/sec numbers has contrast ratio of 2.9.

In light mode, duration and missed samples are 1.63 and 2.15 respectively.

They should be at least 4.5 to meet WCAG AA guidelines.

image image

After

The values suggested by Chrome:

image image

@pablogsal
Copy link
Member

Thanks a lot @hugovk 🖤

@StanFromIreland
Copy link
Member

This also affects the flamegraph output.

@hugovk
Copy link
Member Author

hugovk commented Dec 18, 2025

This also affects the flamegraph output.

In what way? For better, or worse? Please share more details.

@StanFromIreland
Copy link
Member

As in, the CSS is copy-pasted:

.summary-card:nth-child(1) { --i: 0; --card-color: 55, 118, 171; }
.summary-card:nth-child(2) { --i: 1; --card-color: 40, 167, 69; }
.summary-card:nth-child(3) { --i: 2; --card-color: 255, 193, 7; }
.summary-card:nth-child(4) { --i: 3; --card-color: 111, 66, 193; }

@hugovk
Copy link
Member Author

hugovk commented Dec 22, 2025

Ah right, thanks. Let's update those too.

They should be at least 4.5 to meet WCAG AA guidelines.

Actually, that's for normal size text. The heatmap panel is large, so the original colours are at least 3.

We need 4.5 for the flamegraph, and it's hard to find colours that work for both dark and light themes. So this is now updated to different colour for dark/light and re-use via variables.

Also we don't need stat-card for 5th and 6th children, rate-card is used instead. So delete that dead code.

Heatmap:

image image

Flamegraph:

image image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants