gh-142966: ctypes.POINTER.set_type also resets format#142967
Merged
encukou merged 5 commits intopython:mainfrom Jan 26, 2026
Merged
gh-142966: ctypes.POINTER.set_type also resets format#142967encukou merged 5 commits intopython:mainfrom
encukou merged 5 commits intopython:mainfrom
Conversation
aisk
reviewed
Dec 19, 2025
Misc/NEWS.d/next/Library/2025-12-19-11-30-31.gh-issue-142966.PzGiv2.rst
Outdated
Show resolved
Hide resolved
Member
|
Hi, please check my comment in the original issue: #142966 (comment) |
Member
|
Thanks! Let's fix it even though it's deprecated. Could you make this part of Please put the |
…zGiv2.rst Co-authored-by: AN Long <aisk@users.noreply.github.com>
Contributor
Author
|
Thank you for the review! |
Member
|
Hi, please avoid force push in the future, see the Dev Guide. |
thunder-coding
pushed a commit
to thunder-coding/cpython
that referenced
this pull request
Feb 15, 2026
…onGH-142967) Make the deprecated set_type method resets the format, using the same code as in type initialization. Implementation note: this was done in PyCPointerType_init after calling PyCPointerType_SetProto, but was forgotten after in PyCPointerType_set_type_impl's call to PyCPointerType_SetProto. With this change, setting the format is conceptually part of setting proto (i.e. the pointed-to type). Co-authored-by: AN Long <aisk@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.