Skip to content

gh-143253: Add libabigail suppression file for internal types #143254

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hugovk merged 4 commits into from
Jan 12, 2026
+29 −1
Merged

gh-143253: Add libabigail suppression file for internal types #143254

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
92ef74f
gh-143253: Add libabigail suppression file for internal types
pablogsal Dec 28, 2025
2b38a56
Add _PyRuntime
encukou Jan 7, 2026
74f8751
Add myself to CODEOWNERS
encukou Jan 7, 2026
0b664d2
Merge pull request #120 from encukou/abigail
pablogsal Jan 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .github/CODEOWNERS
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -143,6 +143,9 @@ Misc/externals.spdx.json @sethmlarson
Misc/sbom.spdx.json @sethmlarson
Tools/build/generate_sbom.py @sethmlarson

# ABI check
Misc/libabigail.abignore @encukou


# ----------------------------------------------------------------------------
# Platform Support
Expand Down
2 changes: 1 addition & 1 deletion Makefile.pre.in
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1883,7 +1883,7 @@ regen-abidump: all

.PHONY: check-abidump
check-abidump: all
abidiff $(srcdir)/Doc/data/python$(LDVERSION).abi "libpython$(LDVERSION).so" --drop-private-types --no-architecture --no-added-syms
abidiff $(srcdir)/Doc/data/python$(LDVERSION).abi "libpython$(LDVERSION).so" --drop-private-types --no-architecture --no-added-syms --suppressions $(srcdir)/Misc/libabigail.abignore

.PHONY: regen-limited-abi
regen-limited-abi: all
Expand Down
25 changes: 25 additions & 0 deletions Misc/libabigail.abignore
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,25 @@
# libabigail suppression file for CPython ABI checks
#
# Suppress types defined directly in internal headers (pycore_*.h)
# Regex matches filenames NOT starting with "pycore_", so pycore_* types are suppressed.
[suppress_type]
source_location_not_regexp = ^([^p]|p[^y]|py[^c]|pyc[^o]|pyco[^r]|pycor[^e]|pycore[^_])
Copy link
Member

@Yhg1s Yhg1s Jan 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So weird that there isn't a source_location_regexp and so we have to play these stupid double-negation games.

accessed_through = pointer

# Suppress public typedefs that alias internal structs.
# These are public names but their underlying struct layout is internal.
[suppress_type]
name = PyInterpreterState
accessed_through = pointer

[suppress_type]
name = _PyRuntimeState
accessed_through = pointer

[suppress_type]
name = PyThreadState
Copy link
Contributor

@kumaraditya303 kumaraditya303 Jan 10, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this covers _PyThreadStateImpl as well? If not I think we should add that as well.

Copy link
Member

@encukou encukou Jan 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That is defined in Include/internal/pycore_tstate.h, so it's covered by the first suppress_type.

accessed_through = pointer

[suppress_variable]
name = _PyRuntime
type_name = _PyRuntimeState
Loading