gh-143346: Fix calculation of the line width for wrapped Base64 in plistlib #143347
+66
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
serhiy-storchaka
commented
Jan 2, 2026
| b'</array>\n' | ||
| b'</plist>\n') | ||
|
|
||
| pl = dumps_with_indent(data, b' \t') |
Member
Author
There was a problem hiding this comment.
This catches the original bug.
| b'</array>\n' | ||
| b'</plist>\n') | ||
|
|
||
| pl = dumps_with_indent(data, b'\t ') |
Member
Author
There was a problem hiding this comment.
This catches a bug in my initial fix in #143216.
| writer.write(data) | ||
| return fp.getvalue() | ||
|
|
||
| pl = dumps_with_indent(data, b' ') |
Member
Author
There was a problem hiding this comment.
This tests non-default indentation.
serhiy-storchaka
added
needs backport to 3.13
… in plistlib It was incorrect in case of mixed tabs and spaces in indentation.
serhiy-storchaka
force-pushed
the
plistlib-base64-indent
branch
from
5be5810 to
389a103
Compare
|
Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jan 12, 2026
… in plistlib (pythonGH-143347) It was incorrect in case of mixed tabs and spaces in indentation. (cherry picked from commit 5f28aa2) Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
|
GH-143719 is a backport of this pull request to the 3.14 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jan 12, 2026
… in plistlib (pythonGH-143347) It was incorrect in case of mixed tabs and spaces in indentation. (cherry picked from commit 5f28aa2) Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
|
GH-143720 is a backport of this pull request to the 3.13 branch. |
serhiy-storchaka
added a commit
that referenced
this pull request
Jan 12, 2026
serhiy-storchaka
added a commit
that referenced
this pull request
Jan 12, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was incorrect in case of mixed tabs and spaces in indentation.