Skip to content

Conversation

@tiran
Copy link
Member

@tiran tiran commented Jul 1, 2019

SSLContext.post_handshake_auth = True no longer sets
SSL_VERIFY_POST_HANDSHAKE verify flag for client connections. Although the
option is documented as ignored for clients, OpenSSL implicitly enables cert
chain validation when the flag is set.

Signed-off-by: Christian Heimes christian@python.org

https://bugs.python.org/issue37428
(cherry picked from commit f0f5930)

https://bugs.python.org/issue37428

…4421)

SSLContext.post_handshake_auth = True no longer sets
SSL_VERIFY_POST_HANDSHAKE verify flag for client connections. Although the
option is documented as ignored for clients, OpenSSL implicitly enables cert
chain validation when the flag is set.

Signed-off-by: Christian Heimes <christian@python.org>

https://bugs.python.org/issue37428
(cherry picked from commit f0f5930)

Co-authored-by: Christian Heimes <christian@python.org>
@bedevere-bot bedevere-bot added type-bug An unexpected behavior, bug, or error awaiting core review labels Jul 1, 2019
@tiran tiran changed the title [3.8] bpo-37428: Don't set PHA verify flag on client side (GH-14421) [3.8] bpo-37428: Don't set PHA verify flag on client side (GH-14494) Jul 1, 2019
@tiran tiran merged commit f22c4cf into python:3.8 Jul 1, 2019
@tiran
Copy link
Member Author

tiran commented Jul 1, 2019

GH limits the title to 72 chars and didn't let me merge this PR with commit message [3.8] [bpo-37428](https://bugs.python.org/issue37428): Don't set PHA verify flag on client side (GH-14421) (GH-14493).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type-bug An unexpected behavior, bug, or error

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants