[3.7] bpo-37579: Improve equality behavior for pure Python datetime and time (GH-14726) #14745
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nd time (pythonGH-14726) Returns NotImplemented for timedelta and time in __eq__ for different types in Python implementation, which matches the C implementation. This also adds tests to enforce that these objects will fall back to the right hand side's __eq__ and/or __ne__ implementation. bpo-37579 (cherry picked from commit e6b46aa) Co-authored-by: Xtreak <tir.karthi@gmail.com>
pganssle
approved these changes
Jul 13, 2019
Member
Author
|
@pganssle The issue was closed as resolved. Could this also be merged? |
Member
|
@tirkarthi Oh sorry, I thought Miss Islington did the merges automatically on CI pass after approval. |
Member
Author
|
No problem, Thanks :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Returns NotImplemented for timedelta and time in eq for different types in Python implementation, which matches the C implementation.
This also adds tests to enforce that these objects will fall back to the right hand side's eq and/or ne implementation.
bpo-37579
(cherry picked from commit e6b46aa)
Co-authored-by: Xtreak tir.karthi@gmail.com
https://bugs.python.org/issue37579