Skip to content

Conversation

@serhiy-storchaka
Copy link
Member

@serhiy-storchaka serhiy-storchaka commented Jul 28, 2019

There was a discrepancy between the Python and C implementations.

This is a part of #14952 which should be backported.

https://bugs.python.org/issue37685

…one.

There was a discrepancy between the Python and C implementations.
@serhiy-storchaka serhiy-storchaka merged commit 17e5264 into python:master Aug 4, 2019
@miss-islington
Copy link
Contributor

Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 2.7, 3.7, 3.8.
🐍🍒⛏🤖

@serhiy-storchaka serhiy-storchaka deleted the datetime-comparisons branch August 4, 2019 09:38
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Aug 4, 2019
…one. (pythonGH-14996)

There was a discrepancy between the Python and C implementations.

Add singletons ALWAYS_EQ, LARGEST and SMALLEST in test.support
to test mixed type comparison.
(cherry picked from commit 17e5264)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
@bedevere-bot
Copy link

GH-15102 is a backport of this pull request to the 3.8 branch.

@miss-islington
Copy link
Contributor

Sorry, @serhiy-storchaka, I could not cleanly backport this to 3.7 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 17e52649c0e7e9389f1cc2444a53f059e24e6bca 3.7

@miss-islington
Copy link
Contributor

Sorry @serhiy-storchaka, I had trouble checking out the 2.7 backport branch.
Please backport using cherry_picker on command line.
cherry_picker 17e52649c0e7e9389f1cc2444a53f059e24e6bca 2.7

miss-islington added a commit that referenced this pull request Aug 4, 2019
…one. (GH-14996)

There was a discrepancy between the Python and C implementations.

Add singletons ALWAYS_EQ, LARGEST and SMALLEST in test.support
to test mixed type comparison.
(cherry picked from commit 17e5264)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
serhiy-storchaka added a commit to serhiy-storchaka/cpython that referenced this pull request Aug 4, 2019
….timezone. (pythonGH-14996)

There was a discrepancy between the Python and C implementations.

Add singletons ALWAYS_EQ, LARGEST and SMALLEST in test.support
to test mixed type comparison..
(cherry picked from commit 17e5264)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
@bedevere-bot
Copy link

GH-15104 is a backport of this pull request to the 3.7 branch.

serhiy-storchaka added a commit that referenced this pull request Aug 4, 2019
….timezone. (GH-14996) (GH-15104)

There was a discrepancy between the Python and C implementations.

Add singletons ALWAYS_EQ, LARGEST and SMALLEST in test.support
to test mixed type comparison.
(cherry picked from commit 17e5264)
lisroach pushed a commit to lisroach/cpython that referenced this pull request Sep 10, 2019
…one. (pythonGH-14996)

There was a discrepancy between the Python and C implementations.

Add singletons ALWAYS_EQ, LARGEST and SMALLEST in test.support
to test mixed type comparison.
DinoV pushed a commit to DinoV/cpython that referenced this pull request Jan 14, 2020
…one. (pythonGH-14996)

There was a discrepancy between the Python and C implementations.

Add singletons ALWAYS_EQ, LARGEST and SMALLEST in test.support
to test mixed type comparison.
websurfer5 pushed a commit to websurfer5/cpython that referenced this pull request Jul 20, 2020
…one. (pythonGH-14996)

There was a discrepancy between the Python and C implementations.

Add singletons ALWAYS_EQ, LARGEST and SMALLEST in test.support
to test mixed type comparison.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type-bug An unexpected behavior, bug, or error

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants