Skip to content

Conversation

@rsanger
Copy link
Contributor

@rsanger rsanger commented Aug 3, 2019

bz2.open()'s default mode is rb, not r

Minor doc fix, so no issue number.

bz2.open()'s default mode is rb, not r
@the-knights-who-say-ni
Copy link

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA).

Unfortunately we couldn't find an account corresponding to your GitHub username on bugs.python.org (b.p.o) to verify you have signed the CLA (this might be simply due to a missing "GitHub Name" entry in your b.p.o account settings). This is necessary for legal reasons before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

You can check yourself to see if the CLA has been received.

Thanks again for your contribution, we look forward to reviewing it!

@bedevere-bot bedevere-bot added docs Documentation in the Doc dir awaiting review labels Aug 3, 2019
@rsanger rsanger changed the title Fix docs: bz.open default mode Fix docs: bz2.open default mode Aug 4, 2019
Copy link
Member

@tirkarthi tirkarthi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM since "rb" makes it more explicit and is consistent with the below sentence about default value and the signature. Thanks.

@Yhg1s Yhg1s merged commit bb668f7 into python:master Sep 9, 2019
websurfer5 pushed a commit to websurfer5/cpython that referenced this pull request Jul 20, 2020
bz2.open()'s default mode is rb, not r
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs Documentation in the Doc dir skip issue skip news

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants