[2.7] bpo-30310: tkFont now supports unicode options (e.g. font family). #1567
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
terryjreedy
requested changes
May 13, 2017
Member
terryjreedy
left a comment
terryjreedy
left a comment
There was a problem hiding this comment.
Needs currently failing test fixed by patch. See issue for suggestion.
Member
Author
|
Is this good to you @terryjreedy? |
terryjreedy
approved these changes
May 26, 2017
Member
|
I seem to have fixed the News merge conflict (until there is another one ;-). If you are happy with this, push before there is another conflict, and the need for another round of tests ;-). |
Member
|
Sorry for delay. Had unavoidable family business to attend to. |
Member
Author
|
Thank you for your review. |
serhiy-storchaka
added a commit
to serhiy-storchaka/cpython
that referenced
this pull request
May 27, 2017
serhiy-storchaka
added a commit
that referenced
this pull request
May 27, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.