bpo-30394: smtplib leaves open sockets around if SMTPConnectError is raised in __init__ #1700
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RFC2821 S3.1 P3 server MUST wait for us to QUIT.
|
@jhillacre, thanks for your PR! By analyzing the history of the files in this pull request, we identified @bitdancer, @warsaw and @giampaolo to be potential reviewers. |
zhangyangyu
approved these changes
May 22, 2017
bitdancer
requested changes
May 22, 2017
Member
bitdancer
left a comment
bitdancer
left a comment
There was a problem hiding this comment.
I made a suggestion for a test on the issue.
bitdancer
approved these changes
May 23, 2017
Member
|
Nevermind, my suggestion was wrong-headed :) |
Member
|
Thanks @jhillacre ! Would you like to make backport PRs? |
matrixise
pushed a commit
to matrixise/cpython
that referenced
this pull request
May 24, 2017
matrixise
pushed a commit
to matrixise/cpython
that referenced
this pull request
May 24, 2017
matrixise
pushed a commit
to matrixise/cpython
that referenced
this pull request
May 24, 2017
This was referenced May 24, 2017
Member
|
Hi @zhangyangyu I just created some PR for the backports for 2.7, 3.5 and 3.6 |
Member
|
Thanks @matrixise , I'll merge them when able to. |
zhangyangyu
pushed a commit
that referenced
this pull request
May 24, 2017
zhangyangyu
pushed a commit
that referenced
this pull request
May 24, 2017
zhangyangyu
pushed a commit
that referenced
this pull request
May 24, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Opening PR based on patch file from https://bugs.python.org/issue30394