Skip to content

Conversation

@rhettinger
Copy link
Contributor

@rhettinger rhettinger commented Nov 10, 2019

@rhettinger rhettinger changed the title bpo-38761: Register WeakSet as a MutableSet WIP bpo-38761: Register WeakSet as a MutableSet Nov 10, 2019
@gvanrossum
Copy link
Member

Maybe move the .register() calls to weakref.py? After all that's where people are supposed to import them from. It would avoid the awkwardness with import and del.

@rhettinger rhettinger merged commit 84ac437 into python:master Nov 11, 2019
@rhettinger rhettinger deleted the weakref_abc branch November 11, 2019 04:12
@gvanrossum
Copy link
Member

What happened here? Don't we normally wait for code reviewers to LGTM?

jacobneiltaylor pushed a commit to jacobneiltaylor/cpython that referenced this pull request Dec 5, 2019
shihai1991 pushed a commit to shihai1991/cpython that referenced this pull request Jan 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants