Skip to content

bpo-39206: Add encoding detecting to modulefinder #17817

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
LucianaMarques wants to merge 11 commits into from
Closed

bpo-39206: Add encoding detecting to modulefinder #17817

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
0c465a0
Add encoding detecting to modulefinder
LucianaMarques Jan 4, 2020
5681b7c
Add encoding test for modulefinder
LucianaMarques Jan 7, 2020
1ddca56
📜🤖 Added by blurb_it.
blurb-it[bot] Jan 6, 2020
ee15717
Standarize file mode to rb
LucianaMarques Jan 14, 2020
df362ca
Remove final empty line to compile()
LucianaMarques Jan 14, 2020
713d1a3
Update news file
LucianaMarques Jan 14, 2020
2b594a9
Update encoding_test
LucianaMarques Jan 14, 2020
294b146
Exclude import of tokenize
LucianaMarques Jan 14, 2020
4b12ad8
Rewrite test_encoding
LucianaMarques Jan 14, 2020
0adc639
Fix added and excluded blank lines
LucianaMarques Jan 14, 2020
87a08b4
Merge branch 'main' into fix-issue-39206
serhiy-storchaka May 23, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions Lib/test/test_modulefinder.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -399,6 +399,12 @@ def test_replace_paths(self):
expected = "co_filename %r changed to %r" % (old_path, new_path)
self.assertIn(expected, output)

def test_encoding(self):
os.makedirs(TEST_DIR, exist_ok=True)
with open(os.path.join(TEST_DIR,'a.py'), 'w', encoding='cp1252') as f:
f.write('# -*- coding: cp1252 -*-\nx = "€"\n')
self._do_test(["a", ["a"], [], [], ""])

def test_extended_opargs(self):
extended_opargs_test = [
"a",
Expand Down
1 change: 1 addition & 0 deletions Misc/NEWS.d/next/Library/2020-01-06-22-39-23.bpo-39206.zKSTwb.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Fix :mod:`modulefinder` to handle :pep:`263` encoding markers - by Luciana Marques