bpo-35108: handle exceptions in inspect.getmembers

Lib/inspect.py

@@ -340,7 +340,9 @@ def getmembers(object, predicate=None):
             for k, v in base.__dict__.items():
                 if isinstance(v, types.DynamicClassAttribute):
                     names.append(k)
-    except AttributeError:
+    except Exception:
+        # Deliberately catch all exceptions for properties that raise
+        # exceptions (e.g. NotImplementedError). See bug #35108
         pass
     for key in names:
         # First try to get the value via getattr.  Some descriptors don't
@@ -360,6 +362,11 @@ def getmembers(object, predicate=None):
                 # could be a (currently) missing slot member, or a buggy
                 # __dir__; discard and move on
                 continue
+        except Exception:
+            # See bug #25108
+            # Attempt to get the value with getattr_static but skip if
+            # even that fails.
+            value = getattr_static(object, key)
         if not predicate or predicate(value):
             results.append((key, value))
         processed.add(key)

Lib/test/test_inspect.py

@@ -1213,6 +1213,17 @@ class C(metaclass=M):
         attrs = [a[0] for a in inspect.getmembers(C)]
         self.assertNotIn('missing', attrs)
 
+    def test_getmembers_property_raises_exception(self):
+        # bpo-35108
+        class A:
+            @property
+            def f(self):
+                raise NotImplementedError
+
+        self.assertIn(("f", A.f), inspect.getmembers(A()))
+
+
+
 class TestIsDataDescriptor(unittest.TestCase):
 
     def test_custom_descriptors(self):

Misc/NEWS.d/next/Library/2020-02-03-09-21-13.bpo-35108.7iPRPL.rst

@@ -0,0 +1 @@
+Handle proprties raising exceptions in :meth:`inspect.getmembers`.