Skip to content

bpo-39630: Update pointers to string literals to be const char * #18510

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
benjaminp merged 1 commit into from
Feb 14, 2020
Merged

bpo-39630: Update pointers to string literals to be const char * #18510

benjaminp merged 1 commit into from
Feb 14, 2020

Conversation

@petdance
Copy link
Contributor

@petdance petdance commented Feb 14, 2020 •
edited by bedevere-bot
Loading

Here are some fixes of char * pointers to literals that should be const char * in these four files.

+++ Objects/frameobject.c
+++ Objects/genobject.c
+++ Python/codecs.c
+++ Python/errors.c

https://bugs.python.org/issue39630

@petdance petdance requested a review from 1st1 as a code owner February 14, 2020 03:27
@benjaminp benjaminp merged commit 7386a70 into python:master Feb 14, 2020
@miss-islington
Copy link
Contributor

miss-islington commented Feb 14, 2020

Thanks @petdance for the PR, and @benjaminp for merging it 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

miss-islington commented Feb 14, 2020

I'm having trouble backporting to 3.8. Reason: 'Error 110 while writing to socket. Connection timed out.'. Please retry by removing and re-adding the needs backport to 3.8 label.

@miss-islington
Copy link
Contributor

miss-islington commented Feb 14, 2020

Thanks @petdance for the PR, and @benjaminp for merging it 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

miss-islington commented Feb 14, 2020

Sorry, @petdance and @benjaminp, I could not cleanly backport this to 3.8 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 7386a70746cf9aaf2d95db75d9201fb124f085df 3.8

benjaminp pushed a commit that referenced this pull request Feb 14, 2020
@petdance @benjaminp
[3.8] closes bpo-39630: Update pointers to string literals to be cons…
b713717 
…t char *. (GH-18510).

(cherry picked from commit 7386a70)

Co-authored-by: Andy Lester <andy@petdance.com>
@bedevere-bot
Copy link

bedevere-bot commented Feb 14, 2020

GH-18511 is a backport of this pull request to the 3.8 branch.

@petdance petdance deleted the bpo-39630 branch February 26, 2020 03:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@1st1 1st1 Awaiting requested review from 1st1

Assignees

@benjaminp benjaminp

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@petdance @miss-islington @bedevere-bot @benjaminp @the-knights-who-say-ni