[3.8] bpo-39548: Fix handling of 'WWW-Authenticate' header for Digest Auth (GH-18338)

[miss-islington]

• bpo-39548: Fix handling of 'WWW-Authenticate' header for Digest authentication

• The 'qop' value in the 'WWW-Authenticate' header is optional. The
  presence of 'qop' in the header should be checked before its value
  is parsed with 'split'.

Signed-off-by: Stephen Balousek stephen@balousek.net

• bpo-39548: Fix handling of 'WWW-Authenticate' header for Digest authentication

• Add NEWS item

Signed-off-by: Stephen Balousek stephen@balousek.net

• Update Misc/NEWS.d/next/Library/2020-02-06-05-33-52.bpo-39548.DF4FFe.rst

Co-Authored-By: Brandt Bucher brandtbucher@gmail.com

Co-authored-by: Brandt Bucher brandtbucher@gmail.com
(cherry picked from commit 5e260e0)

Co-authored-by: Stephen Balousek sbalousek@users.noreply.github.com

https://bugs.python.org/issue39548

[codecov]

Codecov Report

Merging #18712 into 3.8 will increase coverage by 1.19%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##              3.8   #18712       +/-   ##
===========================================
+ Coverage   82.08%   83.28%    +1.19%     
===========================================
  Files        1919     1571      -348     
  Lines      582229   415244   -166985     
  Branches    43736    44484      +748     
===========================================
- Hits       477944   345825   -132119     
+ Misses      94716    59768    -34948     
- Partials     9569     9651       +82     

Impacted Files	Coverage Δ
Lib/test/test_binhex.py	13.33% <0.00%> (-79.78%)	⬇️
Lib/binhex.py	17.84% <0.00%> (-58.49%)	⬇️
Lib/threading.py	47.43% <0.00%> (-30.41%)	⬇️
Lib/test/test_unicodedata.py	90.98% <0.00%> (-7.93%)	⬇️
Lib/tracemalloc.py	85.59% <0.00%> (-5.13%)	⬇️
Lib/test/test_distutils.py	66.66% <0.00%> (-4.77%)	⬇️
Lib/crypt.py	82.85% <0.00%> (-4.45%)	⬇️
Lib/test/libregrtest/setup.py	54.32% <0.00%> (-4.02%)	⬇️
Lib/test/libregrtest/utils.py	82.97% <0.00%> (-3.87%)	⬇️
Lib/distutils/tests/test_bdist_msi.py	56.25% <0.00%> (-3.75%)	⬇️
... and 759 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 45c4112...7953a69. Read the comment docs.

[miss-islington]

@sbalousek and @orsenthil: Status check is done, and it's a success ✅ .

[miss-islington]

@sbalousek and @orsenthil: Status check is done, and it's a success ✅ .

[miss-islington]

@sbalousek and @orsenthil: Status check is done, and it's a failure ❌ .

[miss-islington]

@sbalousek and @orsenthil: Status check is done, and it's a failure ❌ .

[miss-islington]

@sbalousek and @orsenthil: Status check is done, and it's a failure ❌ .

[miss-islington]

@sbalousek and @orsenthil: Status check is done, and it's a failure ❌ .