Skip to content

bpo-41340: Removed fallback implementation for strdup #21634

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
methane merged 6 commits into from
Jul 27, 2020
Merged

bpo-41340: Removed fallback implementation for strdup #21634

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
257533e
Delete strdup.c
Jul 27, 2020
437c834
removed HAVE_STRDUP
Jul 27, 2020
90c8c0a
remove strdup
Jul 27, 2020
3e6a7b9
removed strdup
Jul 27, 2020
fd2334c
📜🤖 Added by blurb_it.
blurb-it[bot] Jul 27, 2020
795a0ed
Update Misc/NEWS.d/next/Core and Builtins/2020-07-27-01-50-06.bpo-413…
Jul 27, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions Misc/NEWS.d/next/Core and Builtins/2020-07-27-01-50-06.bpo-41340.pZXfcF.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Removed fallback implementation for ``strdup``.
12 changes: 0 additions & 12 deletions Python/strdup.c
View file
Open in desktop

This file was deleted.

13 changes: 0 additions & 13 deletions configure
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12829,19 +12829,6 @@ esac

fi

ac_fn_c_check_func "$LINENO" "strdup" "ac_cv_func_strdup"
if test "x$ac_cv_func_strdup" = xyes; then :
$as_echo "#define HAVE_STRDUP 1" >>confdefs.h

else
case " $LIBOBJS " in
*" strdup.$ac_objext "* ) ;;
*) LIBOBJS="$LIBOBJS strdup.$ac_objext"
;;
esac

fi


for ac_func in getpgrp
do :
Expand Down
2 changes: 1 addition & 1 deletion configure.ac
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3970,7 +3970,7 @@ AC_CHECK_FUNCS(forkpty,,
# check for long file support functions
AC_CHECK_FUNCS(fseek64 fseeko fstatvfs ftell64 ftello statvfs)

AC_REPLACE_FUNCS(dup2 strdup)
AC_REPLACE_FUNCS(dup2)
AC_CHECK_FUNCS(getpgrp,
AC_COMPILE_IFELSE([AC_LANG_PROGRAM([[#include <unistd.h>]], [[getpgrp(0);]])],
[AC_DEFINE(GETPGRP_HAVE_ARG, 1, [Define if getpgrp() must be called as getpgrp(0).])],
Expand Down
3 changes: 0 additions & 3 deletions pyconfig.h.in
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1034,9 +1034,6 @@
/* Has stdatomic.h with atomic_int and atomic_uintptr_t */
#undef HAVE_STD_ATOMIC

/* Define to 1 if you have the `strdup' function. */
#undef HAVE_STRDUP

/* Define to 1 if you have the `strftime' function. */
#undef HAVE_STRFTIME

Expand Down