Skip to content

bpo-41370: Add note about ForwardRefs and PEP585 generic types in docs #25183

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
gvanrossum merged 2 commits into from
Apr 4, 2021
Merged

bpo-41370: Add note about ForwardRefs and PEP585 generic types in docs #25183

gvanrossum merged 2 commits into from
Apr 4, 2021

Conversation

@Fidget-Spinner
Copy link
Member

@Fidget-Spinner Fidget-Spinner commented Apr 4, 2021 •
edited by bedevere-bot
Loading

Also fixed a small error in ForwardRef's description regarding list["SomeClass"].

https://bugs.python.org/issue41370

@bedevere-bot bedevere-bot added docs Documentation in the Doc dir awaiting review labels Apr 4, 2021
@Fidget-Spinner
Copy link
Member Author

Fidget-Spinner commented Apr 4, 2021

Labels:
Needs backport to 3.9.
Skip news (Maybe?)

@gvanrossum gvanrossum merged commit 2b5913b into python:master Apr 4, 2021
@bedevere-bot
Copy link

bedevere-bot commented Apr 4, 2021

@gvanrossum: Please replace # with GH- in the commit message next time. Thanks!

@miss-islington
Copy link
Contributor

miss-islington commented Apr 4, 2021

Thanks @Fidget-Spinner for the PR, and @gvanrossum for merging it 🌮🎉.. I'm working now to backport this PR to: 3.9.
🐍🍒⛏🤖

@bedevere-bot
Copy link

bedevere-bot commented Apr 4, 2021

GH-25184 is a backport of this pull request to the 3.9 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Apr 4, 2021
@Fidget-Spinner @miss-islington
bpo-41370: Add note about ForwardRefs and PEP585 generic types in docs (
787aa3b 
pythonGH-25183)

(cherry picked from commit 2b5913b)

Co-authored-by: Ken Jin <28750310+Fidget-Spinner@users.noreply.github.com>
miss-islington added a commit that referenced this pull request Apr 4, 2021
@miss-islington
[3.9] bpo-41370: Add note about ForwardRefs and PEP585 generic types …
d56bcf9 
…in docs (GH-25183) (GH-25184)

(cherry picked from commit 2b5913b)


Co-authored-by: Ken Jin <28750310+Fidget-Spinner@users.noreply.github.com>

Automerge-Triggered-By: GH:gvanrossum
@Fidget-Spinner Fidget-Spinner deleted the Issue41370 branch April 4, 2021 15:38
@Fidget-Spinner
Copy link
Member Author

Fidget-Spinner commented Apr 4, 2021

Thanks Guido!

@wyfo wyfo mannequin mentioned this pull request Apr 20, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gvanrossum gvanrossum gvanrossum approved these changes

@ilevkivskyi ilevkivskyi Awaiting requested review from ilevkivskyi

Assignees

No one assigned

Labels

docs Documentation in the Doc dir skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@Fidget-Spinner @bedevere-bot @miss-islington @gvanrossum @the-knights-who-say-ni