bpo-24301: Do not fail when gzip files have trailing garbage#29847
Open
rhpvorderman wants to merge 3 commits into
Open
bpo-24301: Do not fail when gzip files have trailing garbage#29847rhpvorderman wants to merge 3 commits into
rhpvorderman wants to merge 3 commits into
Conversation
|
This PR is stale because it has been open for 30 days with no activity. |
MaxwellDupre
suggested changes
Feb 27, 2022
Contributor
MaxwellDupre
left a comment
MaxwellDupre
left a comment
There was a problem hiding this comment.
Could you add to docs, please?
I think its important users know what to expect. Does't need much, similar to what you have in NEWS.
Contributor
Author
|
@MaxwellDupre I added some |
|
All commit authors signed the Contributor License Agreement. |
|
Is there any chance of moving this one forward? |
Contributor
Author
|
If the changes as is are deemed OK I am prepared to port them to the newest python version and resolve the conclicts. |
github-actions
Bot
removed
the
stale
|
This PR is stale because it has been open for 30 days with no activity. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Apparently the
gzipcommand line utility and several others display the same behaviour. Python failing here is unexpected.The code was adapted so that trailing garbage emits a warning (just like the gzip cli). The first member is still checked for a correct magic number.
https://bugs.python.org/issue24301