[3.9] bpo-46345: Add a test case for implicit Optional class attribute (GH-30535)
#30568
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ythonGH-30535) (cherry picked from commit 1de6015) Co-authored-by: Nikita Sobolev <mail@sobolevn.me>
miss-islington
requested review from
Fidget-Spinner and
gvanrossum
as code owners
Contributor
Author
|
@sobolevn and @gvanrossum: Status check is done, and it's a failure ❌ . |
Member
|
Let's see if the tests pass before approving this. (The other PR was
backported this far, right?)
…On Wed, Jan 12, 2022 at 3:36 PM Miss Islington (bot) < ***@***.***> wrote:
@sobolevn <https://github.com/sobolevn> and @gvanrossum
<https://github.com/gvanrossum>: Status check is done, and it's a failure
❌ .
—
Reply to this email directly, view it on GitHub
<#30568 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAWCWMTDKKFJMPED5ABBTMDUVYF67ANCNFSM5L2ITKTA>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
You are receiving this because you were mentioned.Message ID:
***@***.***>
--
--Guido van Rossum (python.org/~guido)
|
Contributor
Author
|
@sobolevn and @gvanrossum: Status check is done, and it's a success ✅ . |
gvanrossum
approved these changes
Jan 13, 2022
Member
|
When I take a look at previous PRs, most of adding test cases were not backported. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(cherry picked from commit 1de6015)
Co-authored-by: Nikita Sobolev mail@sobolevn.me
https://bugs.python.org/issue46345