Skip to content

bpo-22536: Skip two non-windows tests on Windows #3202

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
gpshead merged 1 commit into from
Aug 25, 2017
Merged

bpo-22536: Skip two non-windows tests on Windows #3202

gpshead merged 1 commit into from
Aug 25, 2017
+2 −0

Conversation

@gpshead
Copy link
Member

@gpshead gpshead commented Aug 25, 2017 •
edited by bedevere-bot
Loading

Skip the tests added in PR 3194 on Windows as that error message functionality is not (yet?) implemented there.

https://bugs.python.org/issue22536

@gpshead gpshead merged commit a3a6df3 into python:master Aug 25, 2017
gpshead added a commit to gpshead/cpython that referenced this pull request Sep 4, 2017
@gpshead
bpo-22536 [3.6] (pythonGH-3202) skip non-windows tests.
92929c4
@gpshead gpshead mentioned this pull request Sep 4, 2017
Merged
gpshead added a commit that referenced this pull request Sep 4, 2017
@gpshead
bpo-22536 [3.6] Set filename in FileNotFoundError (#3305)
1dba378 
* [3.6] bpo-22536: Set the filename in FileNotFoundError. (GH-3194)

Have the subprocess module set the filename in the FileNotFoundError
exception raised on POSIX systems when the executable or cwd are missing.
(cherry picked from commit 8621bb5)

* bpo-22536 [3.6] (GH-3202) skip non-windows tests.
GadgetSteve pushed a commit to GadgetSteve/cpython that referenced this pull request Sep 10, 2017
@gpshead @GadgetSteve
Skip two tests not intended to pass on Windows. (python#3202)
fb5213b
@gpshead gpshead deleted the subprocess_windows_test_skip branch November 14, 2018 01:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@gpshead @Mariatta @the-knights-who-say-ni @bedevere-bot