Skip to content

gh-90872: Handle negative timeouts for wait on Windows #32079

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jkloth wants to merge 2 commits into
base: main
Choose a base branch
from
+4 −0
Open

gh-90872: Handle negative timeouts for wait on Windows #32079

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cce07ea
bpo-46716: Handle negative timeouts for wait on Windows
jkloth Mar 23, 2022
e00b44e
Merge branch 'main' into issue46716
serhiy-storchaka Feb 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions Lib/subprocess.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1586,8 +1586,12 @@ def _wait(self, timeout):
"""Internal implementation of wait() on Windows."""
if timeout is None:
timeout_millis = _winapi.INFINITE
elif timeout <= 0:
timeout_millis = 0
else:
timeout_millis = int(timeout * 1000)
if timeout_millis >= _winapi.INFINITE:
raise OverflowError('timeout too large to convert to C DWORD')
if self.returncode is None:
# API note: Returns immediately if timeout_millis == 0.
result = _winapi.WaitForSingleObject(self._handle,
Expand Down
Loading