bpo-10381, bpo-32403: What's new entries for changes to datetime#5814
Merged
abalkin merged 2 commits intopython:masterfrom Feb 27, 2018
Merged
bpo-10381, bpo-32403: What's new entries for changes to datetime#5814abalkin merged 2 commits intopython:masterfrom
abalkin merged 2 commits intopython:masterfrom
Conversation
Member
|
@ned-deily - I am not sure what the procedure is for adding What's New in 3.7 entries. Please advise. The text LGTM. |
Member
|
@abalkin After merging to the master branch, you should only need to backport to 3.7 like any other change and that should happen automatically. |
Member
Author
|
Should I try to do some sort of benchmarking before this is merged to give an estimate of the order of magnitude of the speedup? |
Member
|
@pganssle As far as I'm concerned, "significant" is sufficient. Thanks for doing this. |
Contributor
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Feb 27, 2018
…hongh-5814) * Add What's New entry for addition of datetime.timezone to the C API Closes bpo-10381 * Add what's new entry for date and datetime optimizations Closes bpo-32403 (cherry picked from commit 5bd04f9) Co-authored-by: Paul Ganssle <pganssle@users.noreply.github.com>
|
GH-5929 is a backport of this pull request to the 3.7 branch. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds "What's New" entries for two datetime-related improvements I made in #4993 (bpo-32403) and #5032 (bpo-10381).
For the "optimizations" one, I was not sure how best to measure the improvement in speed but I just put "significant". My initial benchmarks suggest that some of the constructors have as much as 100% speed improvement, but none of that was done against an optimized build.
https://bugs.python.org/issue10381