bpo-32758: warn that a couple ast functions can crash the interpreter#5960
Merged
Conversation
brettcannon
added
needs backport to 3.6
docs
Member
Author
|
Got approval for the wording from @serhiy-storchaka in the issue itself, but he also pointed out that there are implicit uses of the troublesome functions in various other places, so the comment needs to spread out a bit more before this PR can get merged. |
Contributor
|
Thanks @brettcannon for the PR 🌮🎉.. I'm working now to backport this PR to: 2.7, 3.6, 3.7. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Mar 9, 2018
…the interpreter (pythonGH-5960) (cherry picked from commit 7a7f100) Co-authored-by: Brett Cannon <brettcannon@users.noreply.github.com>
|
GH-6041 is a backport of this pull request to the 3.7 branch. |
Contributor
|
Sorry, @brettcannon, I could not cleanly backport this to |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Mar 9, 2018
…the interpreter (pythonGH-5960) (cherry picked from commit 7a7f100) Co-authored-by: Brett Cannon <brettcannon@users.noreply.github.com>
|
GH-6042 is a backport of this pull request to the 3.6 branch. |
brettcannon
added a commit
that referenced
this pull request
Mar 9, 2018
brettcannon
added a commit
that referenced
this pull request
Mar 9, 2018
jo2y
pushed a commit
to jo2y/cpython
that referenced
this pull request
Mar 23, 2018
AWhetter
pushed a commit
to AWhetter/cpython
that referenced
this pull request
Oct 3, 2019
…the interpreter (pythonGH-5960) (cherry picked from commit 7a7f100) Co-authored-by: Brett Cannon <brettcannon@users.noreply.github.com>
|
GH-16565 is a backport of this pull request to the 2.7 branch. |
serhiy-storchaka
pushed a commit
that referenced
this pull request
Oct 18, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Both
ast.parse()andast.literal_eval()can trigger a segfault with the appropriate string input due to the recursion depth limit of the AST compiler.https://bugs.python.org/issue32758