bpo-33165: Added stacklevel parameter to logging APIs.#7424
Merged
vsajip merged 2 commits intopython:masterfrom Jun 5, 2018
vsajip:fix-33165
Merged
bpo-33165: Added stacklevel parameter to logging APIs.#7424vsajip merged 2 commits intopython:masterfrom vsajip:fix-33165
vsajip merged 2 commits intopython:masterfrom
vsajip:fix-33165
Conversation
csabella
reviewed
Jun 5, 2018
Doc/library/logging.rst
Outdated
| The third keyword argument is *extra* which can be used to pass a | ||
| The third optional keyword argument is *stacklevel*, which defaults to ``1``. | ||
| If greater than 1, the corresponding number of stack frames are skipped | ||
| when computing the line number and function name set in the LogRecord |
Contributor
There was a problem hiding this comment.
Should LogRecord be a link, i.e. :class:`LogRecord`?
Member
Author
There was a problem hiding this comment.
Yes, I will update the PR. Thanks for spotting it!
ncoghlan
approved these changes
Jun 5, 2018
Contributor
ncoghlan
left a comment
ncoghlan
left a comment
There was a problem hiding this comment.
Yay! Thank you very much for implementing this :)
4 tasks
evandrocoan
added a commit
to evandrocoan/debugtools
that referenced
this pull request
Dec 27, 2019
arguments but 3 were given due: bpo-33165: Added stacklevel parameter to logging APIs python/cpython#7424
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://bugs.python.org/issue33165