[2.7] Docs: fix some wrong words (GH-6987) #7572
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix typos in code comments: bdb.py and configure.ac.. (cherry picked from commit b5c246f) Co-authored-by: Eitan Adler <grimreaper@users.noreply.github.com>
Member
Author
|
@ned-deily I ran autoconf here. Can you check if this is right? It has more changes than I expect.. |
ned-deily
reviewed
Jun 10, 2018
Member
ned-deily
left a comment
ned-deily
left a comment
There was a problem hiding this comment.
The giveaway is that all the diffs are in configure.ac, not in configure. The latter is generated by the autoconf not the former. Looks like the issue is that the 2.7 configure.ac has a lot of trailing spaces cruft that has been there forever and now is probably not the time to change it. Recommend that you revert the edit to configure.ac and just make the changes manually then rerun autoconf.
Member
|
@Mariatta @ned-deily |
Member
|
Thanks for the PR. It has been superseded by #10315. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix typos in code comments: bdb.py and configure.ac..
(cherry picked from commit b5c246f)
Co-authored-by: Eitan Adler grimreaper@users.noreply.github.com