[3.9] bpo-46415: Use f-string for ValueError in ipaddress.ip_{address,network,interface} helper functions (GH-30642) #92226
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rk,interface} helper functions (pythonGH-30642) `IPv*Network` and `IPv*Interface` constructors accept a 2-tuple of (address description, netmask) as the address parameter. When the tuple-based address is used errors are not propagated correctly through the `ipaddress.ip_*` helper because of the %-formatting now expecting several arguments: In [7]: ipaddress.ip_network(("192.168.100.0", "fooo")) ... TypeError: not all arguments converted during string formatting Compared to: In [8]: ipaddress.IPv4Network(("192.168.100.0", "foo")) ... NetmaskValueError: 'foo' is not a valid netmask Use an f-string to make sure the error is always properly formatted. Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com> (cherry picked from commit 52dc9c3) Co-authored-by: Thomas Cellerier <thomascellerier@gmail.com>
Contributor
Author
|
@thomascellerier and @JelleZijlstra: Status check is done, and it's a success ✅ . |
Contributor
Author
|
@thomascellerier and @JelleZijlstra: Status check is done, and it's a success ✅ . |
JelleZijlstra
approved these changes
May 3, 2022
Contributor
Author
|
@thomascellerier and @JelleZijlstra: Status check is done, and it's a success ✅ . |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IPv*NetworkandIPv*Interfaceconstructors accept a 2-tuple of(address description, netmask) as the address parameter.
When the tuple-based address is used errors are not propagated
correctly through the
ipaddress.ip_*helper because of the %-formatting now expecting several arguments:Compared to:
Use an f-string to make sure the error is always properly formatted.
Co-authored-by: Jelle Zijlstra jelle.zijlstra@gmail.com
(cherry picked from commit 52dc9c3)
Co-authored-by: Thomas Cellerier thomascellerier@gmail.com