gh-92780: Improve sqlite3.Connection.create_collation docs #92790
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erlend-aasland
added
skip news
needs backport to 3.9
needs backport to 3.10
Contributor
Author
|
@AdrianIssott, would you mind reviewing this? |
erlend-aasland
commented
May 13, 2022
AlexWaygood
reviewed
May 14, 2022
AlexWaygood
reviewed
May 15, 2022
AlexWaygood
approved these changes
May 15, 2022
Member
AlexWaygood
left a comment
AlexWaygood
left a comment
There was a problem hiding this comment.
Looks good, other than the mishap with ReST :)
Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
|
LGTM 👍 |
Contributor
Author
|
Thanks for the reviews. I'll merge in a day or two. |
Contributor
|
Thanks @erlend-aasland for the PR 🌮🎉.. I'm working now to backport this PR to: 3.9, 3.10, 3.11. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
May 18, 2022
…honGH-92790) Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com> (cherry picked from commit 7ee19e2) Co-authored-by: Erlend Egeberg Aasland <erlend.aasland@protonmail.com>
|
GH-92922 is a backport of this pull request to the 3.11 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
May 18, 2022
…honGH-92790) Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com> (cherry picked from commit 7ee19e2) Co-authored-by: Erlend Egeberg Aasland <erlend.aasland@protonmail.com>
|
GH-92923 is a backport of this pull request to the 3.10 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
May 18, 2022
…honGH-92790) Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com> (cherry picked from commit 7ee19e2) Co-authored-by: Erlend Egeberg Aasland <erlend.aasland@protonmail.com>
|
GH-92924 is a backport of this pull request to the 3.9 branch. |
miss-islington
added a commit
that referenced
this pull request
May 18, 2022
miss-islington
added a commit
that referenced
this pull request
May 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #92780