Skip to content

Conversation

@tiran
Copy link
Member

@tiran tiran commented Jun 26, 2022

It makes it easier to look for module states in sysconfig without
special casing suffixes "_CFLAGS", "_DEPS", "_LDFLAGS", "_OBJS",
and "CTYPES_MALLOC_CLOSURE".

Automerge-Triggered-By: GH:tiran

@tiran tiran added build The build process and cross-build needs backport to 3.11 only security fixes labels Jun 26, 2022
@tiran tiran requested a review from erlend-aasland June 26, 2022 12:07
It makes it easier to look for module states in sysconfig without
special casing suffixes "_CFLAGS", "_DEPS", "_LDFLAGS", "_OBJS",
and "CTYPES_MALLOC_CLOSURE".
Copy link
Contributor

@erlend-aasland erlend-aasland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1
lgtm

@miss-islington
Copy link
Contributor

Thanks @tiran for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

Sorry, @tiran, I could not cleanly backport this to 3.11 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 71868a0066a90519ccc6aeb75673ae882aaa03f0 3.11

@miss-islington miss-islington self-assigned this Jun 27, 2022
@tiran tiran deleted the gh-90005-state branch June 27, 2022 06:59
tiran added a commit to tiran/cpython that referenced this pull request Jun 27, 2022
…pythonGH-94301)

It makes it easier to look for module states in sysconfig without
special casing suffixes "_CFLAGS", "_DEPS", "_LDFLAGS", "_OBJS",
and "CTYPES_MALLOC_CLOSURE"..
(cherry picked from commit 71868a0)

Co-authored-by: Christian Heimes <christian@python.org>
@bedevere-bot bedevere-bot removed the needs backport to 3.11 only security fixes label Jun 27, 2022
@bedevere-bot
Copy link

GH-94317 is a backport of this pull request to the 3.11 branch.

tiran added a commit that referenced this pull request Jun 27, 2022
…4301) (GH-94317)

Co-authored-by: Christian Heimes <christian@python.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

build The build process and cross-build skip news

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants