Skip to content

Conversation

@andresdelfino
Copy link
Contributor

@andresdelfino andresdelfino commented Sep 24, 2018

@andresdelfino
Copy link
Contributor Author

andresdelfino commented Sep 26, 2018

Per @freddrake comment on the issue, this PR would be re-targeted to a maintenance branch, while #9576 would hit master.

@taleinat taleinat changed the base branch from master to 3.7 October 26, 2018 12:44
@taleinat taleinat changed the base branch from 3.7 to master October 26, 2018 12:44
@taleinat taleinat changed the base branch from master to 3.7 October 26, 2018 13:01
@taleinat taleinat force-pushed the bpo-34789-make_parser branch from 0ea7046 to a5c067d Compare October 26, 2018 13:01
@taleinat
Copy link
Contributor

I've changed this to merge into 3.7 and rebased the branch onto the 3.7 branch.

This would need to be backported to 3.6 and 2.7.

@taleinat taleinat changed the title bpo-34789: xml.sax.make_parser expects a list not just any sequence [3.7] bpo-34789: xml.sax.make_parser expects a list not just any sequence Oct 26, 2018
Copy link
Contributor

@taleinat taleinat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@taleinat taleinat merged commit 1487b65 into python:3.7 Oct 26, 2018
@miss-islington
Copy link
Contributor

Thanks @andresdelfino for the PR, and @taleinat for merging it 🌮🎉.. I'm working now to backport this PR to: 2.7, 3.6.
🐍🍒⛏🤖

@bedevere-bot
Copy link

GH-10123 is a backport of this pull request to the 3.6 branch.

@bedevere-bot
Copy link

GH-10124 is a backport of this pull request to the 2.7 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 26, 2018
…ence (pythonGH-9542)

(cherry picked from commit 1487b65)

Co-authored-by: Andrés Delfino <adelfino@gmail.com>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 26, 2018
…ence (pythonGH-9542)

(cherry picked from commit 1487b65)

Co-authored-by: Andrés Delfino <adelfino@gmail.com>
miss-islington added a commit that referenced this pull request Oct 26, 2018
…ence (GH-9542)

(cherry picked from commit 1487b65)

Co-authored-by: Andrés Delfino <adelfino@gmail.com>
miss-islington added a commit that referenced this pull request Oct 26, 2018
…ence (GH-9542)

(cherry picked from commit 1487b65)

Co-authored-by: Andrés Delfino <adelfino@gmail.com>
@andresdelfino andresdelfino deleted the bpo-34789-make_parser branch October 26, 2018 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs Documentation in the Doc dir skip news

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants