Skip to content

Conversation

@lukegarland
Copy link

@lukegarland lukegarland commented Nov 30, 2022

This is a backport to Python 3.10 for bpo-40882: Fix a memory leak in SharedMemory on Windows (GH-20684)

@ghost
Copy link

ghost commented Nov 30, 2022

All commit authors signed the Contributor License Agreement.
CLA signed

@zooba zooba changed the title Backport 85c128e 3.10 [3.10] bpo-40882: Fix a memory leak in SharedMemory on Windows (GH-20684) Dec 1, 2022
@zooba
Copy link
Member

zooba commented Dec 1, 2022

Thanks for the backport! It looks like argument clinic changed enough that it needs to be re-run on the changed file. Should be able to do python Tools\clinic\clinic.py -f Modules\_winapi.c and commit the change to get that last check to pass.

@ZackerySpytz
Copy link
Contributor

Why did you add an extra period in the commit message? Please remove it. I recall that cherry_picker had some sort of bug that could cause issues like this.

@zooba Can you please make sure that the extra period is not there when merging?

@lukegarland lukegarland force-pushed the backport-85c128e-3.10 branch from 502a1d7 to fc30698 Compare December 1, 2022 17:12
@lukegarland
Copy link
Author

Removed the extra period in the commit message, and updated the argument clinic using python Tools\clinic\clinic.py -f Modules\_winapi.c

@ZackerySpytz
Copy link
Contributor

No, you didn't remove it. It looks like you removed the period in 3.10 instead, which is wrong (please add it back).

In the sentence that begins with "In multiprocessing.shared_memory.SharedMemory", you added an extra period at the end. Please remove it.

ZackerySpytz and others added 3 commits December 1, 2022 16:21
…nGH-20684)

In multiprocessing.shared_memory.SharedMemory(), the temporary view
returned by MapViewOfFile() should be unmapped when it is no longer
needed.
(cherry picked from commit 85c128e)

Co-authored-by: Zackery Spytz <zspytz@gmail.com>
@lukegarland lukegarland force-pushed the backport-85c128e-3.10 branch from 8160622 to 9eadb2c Compare December 1, 2022 23:22
@lukegarland
Copy link
Author

Ah, thanks for the clarification. Was looking at the wrong commit. Its fixed now, and all checks pass.

@zooba zooba merged commit b027dd7 into python:3.10 Dec 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants