Re-use joinpath logic in Traversable and MultiplexedPath#250
Merged
Conversation
FFY00
approved these changes
Apr 18, 2022
Member
FFY00
left a comment
FFY00
left a comment
There was a problem hiding this comment.
I had the look at the PR and it seems good. Thank you for splitting each logical change into its own commit.
I only have one note.
| try: | ||
| return next(matches).joinpath(*names) | ||
| except StopIteration: | ||
| raise TraversalError( |
Member
There was a problem hiding this comment.
The only way for this to happen is no arguments being passed, no? Wouldn't checking for that directly make the code easier to read?
Member
Author
There was a problem hiding this comment.
I don't think that's correct. A StopIteration would occur if none of the traversable.name == target in the matches above (including if self.iterdir() yields no results). It's trapping StopIteration on next(matches), not *names. *names can be empty. Maybe only the exception should be trapped for next(matches).
jaraco
commented
Jun 13, 2022
…concrete implementation.
…rts for getting the parts.
jaraco
force-pushed
the
bugfix/MultiplexedPath-descendants
branch
from
779f59e to
1def9a2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Inspired by #248 (comment)