Recognize Hashable as a real protocol, refs #11799#11802
Merged
JelleZijlstra merged 2 commits intopython:masterfrom Mar 24, 2022
sobolevn:issue-11799
Merged
Recognize Hashable as a real protocol, refs #11799#11802JelleZijlstra merged 2 commits intopython:masterfrom sobolevn:issue-11799
Hashable as a real protocol, refs #11799#11802JelleZijlstra merged 2 commits intopython:masterfrom
sobolevn:issue-11799
Conversation
JelleZijlstra
approved these changes
Mar 21, 2022
Contributor
|
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sorry for spamming with PR, but this problem caught my eye 🙂
When this piece of code was checked:
Mypy revealed that
Hashableis() -> object. It happened, becauseis_subtype(explicit_type, default_ret_type, ignore_type_params=True)wasTrue, whereexplicit_type=objectanddefault_ret_type=Hashable. It happened becauseobjecthas__hash__method.The only thing that poped out of my head is to simply exclude protocols from this condition.
I guess that we might double check protocols with
__new__and__init__to be sure. But, I am not able to think of proper test cases for this. Any ideas? Or is my single test good enough?I am adding
pythonevaltest, because of the complexity in howHashableis defined and analyzed in real life.Closes #11799