Skip to content

Make mypy test suite pass mypy type-check on Windows #11895

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
AlexWaygood wants to merge 3 commits into from
Closed

Make mypy test suite pass mypy type-check on Windows #11895

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
88354a9
Make mypy test suite pass mypy on Windows
AlexWaygood Jan 3, 2022
44f9eb7
Update data.py
AlexWaygood Jan 3, 2022
4be969d
Update data.py
AlexWaygood Jan 4, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion mypy/test/data.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
import sys

import pytest
from typing import List, Tuple, Set, Optional, Iterator, Any, Dict, NamedTuple, Union
from typing import Callable, List, Tuple, Set, Optional, Iterator, Any, Dict, NamedTuple, Union

from mypy.test.config import test_data_prefix, test_temp_dir, PREFIX

Expand All @@ -35,6 +35,8 @@ def parse_test_case(case: 'DataDrivenTestCase') -> None:
"""
test_items = parse_test_data(case.data, case.name)
base_path = case.suite.base_path
# this file doesn't type-check on Windows without this line, see #11895
join: Callable[[str, str], str]
if case.suite.native_sep:
join = os.path.join
else:
Expand Down