add support for typing.reveal_type #12117
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sobolevn
approved these changes
Feb 3, 2022
Member
sobolevn
left a comment
sobolevn
left a comment
There was a problem hiding this comment.
Awesome! Thanks!
I guess we also need to sync typeshed for this to work properly with 3.11+ in production,right?
|
|
||
| [case testTypingRevealType] | ||
| from typing import reveal_type | ||
| from typing import reveal_type as show_me_the_type |
Member
There was a problem hiding this comment.
optional nit: Let's also try rt = reveal_type and rt(1)
Member
Author
There was a problem hiding this comment.
That actually doesn't work, probably because at the place in semanal where we recognize reveal_type we can't see through assignments yet. Fixing it would probably be a lot more complicated than this PR, so if we think it's worth fixing, we should do it separately. It doesn't seem too important as no user has asked for it so far.
Member
Author
|
Yes, I'll update typeshed at some point too. Thanks for the review! I'll add some additional tests. |
hauntsaninja
approved these changes
Feb 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add support for
typing.reveal_type(python/cpython#30646) andtyping_extensions.reveal_type(python/typing#1055).Test Plan
Added two test cases.