Update ignore-without-code message#12216
Conversation
hauntsaninja
left a comment
There was a problem hiding this comment.
Thanks! Will leave open for a bit in case PeterJClaw has suggestions.
Don't feel strongly about the space. Grepping public repos seem to be mixed with space and without space. With space matches better how you'd style it if it was a Generic.
Sounds good!
I feel like that's actually a reason to suggest without space 😄 Just to make the distinction that it's not actual Python code. |
|
Thanks for the ping! (& sorry for not getting back to you sooner) IMO with the space is slightly more readable -- the larger gap makes it clearer at a glance that there's two (or more) things being ignored, rather than one with a long name, but I don't feel strongly about this either. |
👍🏻 Let's go with
Ok, with space it is. |
|
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
|
Thank you! |
Description
Followup to #12194 (comment)
Update message for
ignore-without-codeto better capture the spirit of the check.I've changed
usetoconsideras suggested since I also feel this is slightly better. I'm open for other / better ideas.Another question, do we want to remove the space between different error codes? I feel that might be a tick better.
/CC: @hauntsaninja @PeterJCLaw