Skip to content

Add --disallow-untyped-functions#1285

Merged
gvanrossum merged 3 commits intopython:masterfrom
ddfisher:master
Mar 14, 2016
Merged

Add --disallow-untyped-functions#1285
gvanrossum merged 3 commits intopython:masterfrom
ddfisher:master

Conversation

@ddfisher
Copy link
Collaborator

This is something we want to add sooner or later, so I figured I'd just add it now that someone's explicitly asked for it. This catches ~10 incomplete signatures in builtins.pyi and typing.pyi, which would need to be fixed up in a separate typeshed PR.

Fixes #1282.

@gvanrossum
Copy link
Member

  • Is there no way to have a unit test for this? It's not very complex but it could still easily be broken by other changes.
  • Could you fix typeshed (at least builtins and typing) before merging this?
  • I think the meaning of the option would be clearer if it was disallow-untyped-defs.

@ddfisher
Copy link
Collaborator Author

  • Not sure I see this being done for other flags currently, but it seems like a good idea -- I'll see how difficult it is.
  • Looks like you synced typeshed. Thanks!
  • I agree. Changed!

@gvanrossum
Copy link
Member

Let me know about the unit tests.

@ddfisher
Copy link
Collaborator Author

Added unit tests!

gvanrossum added a commit that referenced this pull request Mar 14, 2016
Add `--disallow-untyped-functions`
@gvanrossum gvanrossum merged commit 7b23106 into python:master Mar 14, 2016
@ilinum ilinum mentioned this pull request May 27, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Enforce Type Hints

2 participants