Suggest using upper bound for unbound tvar #13730
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also don't complain about other TypeVarLikeTypes Implements python#13166 (comment)
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
1 similar comment
Contributor
|
Diff from mypy_primer, showing the effect of this PR on open source code: vision (https://github.com/pytorch/vision)
+ torchvision/models/_api.py:118: note: Consider using the upper bound "WeightsEnum" instead
+ torchvision/models/_api.py:222: note: Consider using the upper bound "Any" instead
artigraph (https://github.com/artigraph/artigraph)
+ src/arti/internal/dispatch.py:36: note: Consider using the upper bound "Callable[..., Any]" instead
pandera (https://github.com/pandera-dev/pandera)
+ pandera/engines/engine.py:184: note: Consider using the upper bound "DataType" instead
spark (https://github.com/apache/spark)
+ python/pyspark/ml/wrapper.py:271: note: Consider using the upper bound "JavaParams" instead
|
ilevkivskyi
approved these changes
Sep 26, 2022
This was referenced Sep 30, 2022
ilevkivskyi
pushed a commit
that referenced
this pull request
Oct 2, 2022
Also don't complain about other TypeVarLikeTypes Implements #13166 (comment)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also don't complain about other TypeVarLikeTypes
Implements #13166 (comment)