Skip to content

Stubtest: Fix __mypy-replace false positives #15689

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hauntsaninja merged 6 commits into from
Jul 22, 2023
Merged

Stubtest: Fix __mypy-replace false positives #15689

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
9daef78
Stubtest: Fix `__mypy-replace` false positives
AlexWaygood Jul 16, 2023
b1c008b
Rename flag to `internal_fictional`
AlexWaygood Jul 16, 2023
54347e5
Update mypy/nodes.py
AlexWaygood Jul 16, 2023
e83b124
Revert alll changes
AlexWaygood Jul 22, 2023
20a17ca
Merge branch 'master' into stubtest-dataclasses
AlexWaygood Jul 22, 2023
d9ca332
Just filter out all non-identifiers from stubtest names to check
AlexWaygood Jul 22, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion mypy/stubtest.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -496,7 +496,11 @@ def verify_typeinfo(
)

# Check everything already defined on the stub class itself (i.e. not inherited)
to_check = set(stub.names)
#
# Filter out non-identifier names, as these are (hopefully always?) whacky/fictional things
# (like __mypy-replace or __mypy-post_init, etc.) that don't exist at runtime,
# and exist purely for internal mypy reasons
to_check = {name for name in stub.names if name.isidentifier()}
# Check all public things on the runtime class
to_check.update(
m for m in vars(runtime) if not is_probably_private(m) and m not in IGNORABLE_CLASS_DUNDERS
Expand Down