Skip to content

Error for assignment of functional Enum to variable of different name#16805

Merged
JukkaL merged 2 commits intopython:masterfrom
hauntsaninja:enum-wrong-name
Apr 17, 2024
Merged

Error for assignment of functional Enum to variable of different name#16805
JukkaL merged 2 commits intopython:masterfrom
hauntsaninja:enum-wrong-name

Conversation

@hauntsaninja
Copy link
Collaborator

@github-actions
Copy link
Contributor

Diff from mypy_primer, showing the effect of this PR on open source code:

psycopg (https://github.com/psycopg/psycopg)
+ tests/types/test_enum.py:309: error: String argument 1 "RenamedEnum" to enum.Enum(...) does not match variable name "enum"  [misc]
+ tests/types/test_enum.py:321: error: String argument 1 "LargerEnum" to enum.Enum(...) does not match variable name "enum"  [misc]
+ tests/types/test_enum.py:336: error: String argument 1 "SmallerEnum" to enum.Enum(...) does not match variable name "enum"  [misc]

jax (https://github.com/google/jax)
+ jax/_src/pretty_printer.py:150: error: String argument 1 "_Color" to enum.Enum(...) does not match variable name "Color"  [misc]
+ jax/_src/pretty_printer.py:152: error: String argument 1 "_Intensity" to enum.Enum(...) does not match variable name "Intensity"  [misc]

graphql-core (https://github.com/graphql-python/graphql-core)
+ tests/type/test_definition.py:701: error: String argument 1 "Colors" to enum.Enum(...) does not match variable name "colors"  [misc]
+ tests/type/test_definition.py:709: error: String argument 1 "Colors" to enum.Enum(...) does not match variable name "colors"  [misc]
+ tests/type/test_definition.py:717: error: String argument 1 "Colors" to enum.Enum(...) does not match variable name "colors"  [misc]
+ tests/type/test_definition.py:725: error: String argument 1 "Colors" to enum.Enum(...) does not match variable name "colors"  [misc]

@JukkaL JukkaL merged commit df35dcf into python:master Apr 17, 2024
@hauntsaninja hauntsaninja deleted the enum-wrong-name branch October 15, 2024 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants