Skip to content

Keep Any when restricting Union in isinstance #2446

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JukkaL merged 2 commits into from
Nov 15, 2016
Merged

Keep Any when restricting Union in isinstance #2446

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0cc2077
On fix-alias-crashes: Union Any
ilevkivskyi Nov 13, 2016
7a7de5b
Fix typo in test
ilevkivskyi Nov 13, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion mypy/subtypes.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -345,7 +345,8 @@ def restrict_subtype_away(t: Type, s: Type) -> Type:
Currently just remove elements of a union type.
"""
if isinstance(t, UnionType):
new_items = [item for item in t.items if not is_subtype(item, s)]
new_items = [item for item in t.items if (not is_subtype(item, s)
or isinstance(item, AnyType))]
return UnionType.make_union(new_items)
else:
return t
Expand Down
11 changes: 11 additions & 0 deletions test-data/unit/check-unions.test
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,17 @@ def f(x: Union[int, str]) -> None:
[out]
main: note: In function "f":

[case testUnionAnyIsInstance]
from typing import Any, Union

def func(v:Union[int, Any]) -> None:
if isinstance(v, int):
reveal_type(v) # E: Revealed type is 'builtins.int'
else:
reveal_type(v) # E: Revealed type is 'Any'
[builtins fixtures/isinstance.pyi]
[out]
main: note: In function "func":

[case testUnionAttributeAccess]
from typing import Union
Expand Down