New semantic analyzer: Fix (de)serialization of broken named tuples#6421
Merged
ilevkivskyi merged 6 commits intopython:masterfrom Feb 18, 2019
Merged
New semantic analyzer: Fix (de)serialization of broken named tuples#6421ilevkivskyi merged 6 commits intopython:masterfrom
ilevkivskyi merged 6 commits intopython:masterfrom
Conversation
JukkaL
reviewed
Feb 18, 2019
Collaborator
JukkaL
left a comment
JukkaL
left a comment
There was a problem hiding this comment.
Left some requests for clarification, since this is some pretty tricky code.
| semantic analyzer will perform this patch for us when processing stale | ||
| SCCs. | ||
| """ | ||
| Analyzer = Union[SemanticAnalyzerPass2, NewSemanticAnalyzer] # noqa |
Collaborator
There was a problem hiding this comment.
What's this change? Is is related to the rest of this PR?
Member
Author
There was a problem hiding this comment.
This is needed because otherwise incremental tests crash with the new analyzer (I added couple incremental tests) with something like 'BuildManager' doesn't have attribute 'semantic_analyzer'.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #6413
In my original PR I missed the fact that "broken" named tuples (those where variable name and named tuple name are different) are stored under both names (one to actually access it, and other for (de)serialization).
I also extend the semantic analyzer API, and clean-up/clarify the symbol adding logic a bit.