Skip to content

New analyser: Complain about type variable redefinition only after we decided it is valid#7093

Merged
JukkaL merged 1 commit intopython:masterfrom
ilevkivskyi:newan-no-dummy-err-typevar
Jun 28, 2019
Merged

New analyser: Complain about type variable redefinition only after we decided it is valid#7093
JukkaL merged 1 commit intopython:masterfrom
ilevkivskyi:newan-no-dummy-err-typevar

Conversation

@ilevkivskyi
Copy link
Copy Markdown
Member

Fixes #6957

Using the opportunity, I do a tiny refactoring. The only change in the logic is switching the order of things.

@ilevkivskyi ilevkivskyi requested a review from JukkaL June 28, 2019 15:05
Copy link
Copy Markdown
Collaborator

@JukkaL JukkaL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense!

@JukkaL JukkaL merged commit cded69d into python:master Jun 28, 2019
@ilevkivskyi ilevkivskyi deleted the newan-no-dummy-err-typevar branch June 28, 2019 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

New semantic analyzer: invalid type variable produces additional error

2 participants